Skip to content

docs: typo in comment for unused variables handling #19870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

leopardracer
Copy link
Contributor

Description:
Corrects a typo in the comment within the no-unused-vars rule, improving code clarity and documentation.

@leopardracer leopardracer requested a review from a team as a code owner June 17, 2025 16:12
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 17, 2025
Copy link

linux-foundation-easycla bot commented Jun 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@eslint-github-bot
Copy link

Hi @leopardracer!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

Copy link

netlify bot commented Jun 17, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 5cd04dd
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/685415a3ca25d40008e6d059

@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jun 17, 2025
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leopardracer, thanks for the PR. Can you also sign the CLA.

@@ -1152,7 +1152,7 @@ module.exports = {

// fix for { a: { b } }
if (parentNode.parent.type === "ObjectPattern") {
// fix for unused variables in dectructured object with single property in variable decalartion and function parameter
// fix for unused variables in dectructured object with single property in variable declaration and function parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// fix for unused variables in dectructured object with single property in variable declaration and function parameter
// fix for unused variables in destructured object with single property in variable declaration and function parameter

Seems there is an another typo.

@eslint-github-bot
Copy link

Hi @leopardracer!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@Tanujkanti4441 Tanujkanti4441 changed the title Fix Typo in Comment for Unused Variables Handling fix: Typo in Comment for Unused Variables Handling Jun 17, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 17, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 18, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Jun 18, 2025
@lumirlumir lumirlumir changed the title fix: Typo in Comment for Unused Variables Handling chore: Typo in Comment for Unused Variables Handling Jun 18, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 18, 2025
@Tanujkanti4441 Tanujkanti4441 removed the bug ESLint is working incorrectly label Jun 18, 2025
@leopardracer leopardracer changed the title chore: Typo in Comment for Unused Variables Handling fix: typo in comment for unused variables handling Jun 19, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 19, 2025
@leopardracer
Copy link
Contributor Author

@Tanujkanti4441

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas changed the title fix: typo in comment for unused variables handling docs: typo in comment for unused variables handling Jun 19, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 19, 2025
@nzakas nzakas merged commit 20158b0 into eslint:main Jun 19, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly chore This change is not user-facing documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants