Skip to content

fix: use process.version in --env-info #19865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

TKDev7
Copy link
Contributor

@TKDev7 TKDev7 commented Jun 16, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Modified the --env-info command to use process.version instead of spawning node --version to get the Node.js version.

Fixes #19848

Is there anything you'd like reviewers to focus on?

@TKDev7 TKDev7 requested a review from a team as a code owner June 16, 2025 20:38
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 16, 2025
Copy link

netlify bot commented Jun 16, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0881ce8
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/685080e21db6fc00085547fd

@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 16, 2025
@lumirlumir lumirlumir added accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 17, 2025
@nzakas nzakas moved this from Needs Triage to Triaging in Triage Jun 17, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like another review before merging.

@nzakas nzakas moved this from Triaging to Second Review Needed in Triage Jun 17, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic changed the title fix: use process.version in env-info fix: use process.version in --env-info Jun 17, 2025
@mdjermanovic mdjermanovic merged commit 7dabc38 into eslint:main Jun 17, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly contributor pool
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: eslint --env-info doesn't report correct Node/eslint version
4 participants