feat: add auto-accessor fields support to class-methods-use-this #19789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mdjermanovic
reviewed
Jun 2, 2025
mdjermanovic
reviewed
Jun 2, 2025
mdjermanovic
reviewed
Jun 2, 2025
mdjermanovic
previously approved these changes
Jun 3, 2025
|
Code LGTM. Accessor properties are actually part of the decorators proposal, which is now in stage 3. I'm not sure if it makes sense to call this a TypeScript feature in the docs, especially given that the node type isn't TypeScript-specific (defined in ESTree). While Espree doesn't yet support this syntax (because it's not stage 4) and TypeScript does, that will change soon. Maybe we should call this an "stage 3 syntax" rather than a TypeScript feature? |
|
@sethamus please double-check your spam folder. I sent you an email earlier this week. 😄 |
|
@nzakas Yes, sorry, I replied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added support for TypeScript auto-accessor fields in the class-methods-use-this rule, aligning with the behavior of @typescript-eslint/class-methods-use-this. The rule now reports an error when an auto-accessor field (declared with the accessor keyword) doesn't use
thisin its initializer function.Is there anything you'd like reviewers to focus on?