Skip to content

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #19633

Is there anything you'd like reviewers to focus on?

@snitin315 snitin315 requested a review from a team as a code owner April 18, 2025 16:57
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 18, 2025
@eslint-github-bot
Copy link

Hi @snitin315!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 1b64a7d
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6802847010d3f800088e5aae

@snitin315 snitin315 changed the title Fix/ruletester types fix: update RuleTester.run() type Apr 18, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 18, 2025
@@ -35,7 +35,6 @@ import type {
LanguageOptions as GenericLanguageOptions,
RuleDefinition,
RuleContext as CoreRuleContext,
RuleContextTypeOptions,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to wait for the patch release window to close before merging.

@nzakas nzakas moved this from Needs Triage to Merge Candidates in Triage Apr 18, 2025
@snitin315 snitin315 added accepted There is consensus among the team that this change meets the criteria for inclusion types Related to TypeScript types and removed bug ESLint is working incorrectly labels Apr 19, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@mdjermanovic mdjermanovic merged commit 17bae69 into main Apr 23, 2025
31 checks passed
@mdjermanovic mdjermanovic deleted the fix/ruletester-types branch April 23, 2025 17:31
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Change Request: Support passing RuleDefinition type to the RuleTester.run() method
4 participants