Skip to content

feat: add reportGlobalThis to no-shadow-restricted-names #19670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025

Conversation

sethamus
Copy link
Contributor

@sethamus sethamus commented Apr 29, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Added a new reportGlobalThis option to the no-shadow-restricted-names rule.
  • Updated the rule’s schema, implementation, and documentation to support and describe the new option.
  • Updated the TypeScript types to include the new option.
  • Added tests.

Is there anything you'd like reviewers to focus on?

Closes #19658

@sethamus sethamus requested a review from a team as a code owner April 29, 2025 11:01
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 29, 2025
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Apr 29, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Apr 29, 2025
Copy link

netlify bot commented Apr 29, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 8fba831
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/681326b5cdd748000848d4f3

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Apr 30, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Apr 30, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @fasttime to verify.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit e9754e7 into eslint:main May 2, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: support globalThis in no-shadow-restricted-names
3 participants