fix: don't crash on tests with circular references in RuleTester
#19664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #19646
What changes did you make? (Give an overview)
Updated
isSerializable
(lib/shared/serialization.js
) to not cause a stack overflow error when the passed object has circular references, and in that case returnfalse
because objects with circular references are not JSON-serializable.Also updated
freezeDeeply
(inlib/rule-tester/rule-tester.js
) to to not cause a stack overflow error when the passed object has circular references.Is there anything you'd like reviewers to focus on?
This is a very edge case, so I was more concerned if it would affect performance. By my performance testing, which was to run all core rules tests, it doesn't seem to significantly affect execution time.
Before:
After: