Skip to content

fix: add namespace to Plugin.meta type #19661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Updates Plugin.meta type with namespace property, as per Flat Config Extends RFC.

What changes did you make? (Give an overview)

Updated lib/types/index.d.ts and types tests.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner April 26, 2025 14:44
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 26, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 26, 2025
Copy link

netlify bot commented Apr 26, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 314b7de
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/680cf145033a010007842ff5

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Since this was PR was opened on a weekend we must hold off from merging until next week.

@fasttime fasttime moved this from Needs Triage to Implementing in Triage Apr 27, 2025
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 27, 2025
@fasttime fasttime moved this from Implementing to Merge Candidates in Triage Apr 27, 2025
@fasttime fasttime added the types Related to TypeScript types label Apr 27, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 9736d5d into main Apr 28, 2025
31 checks passed
@snitin315 snitin315 deleted the types-plugin-namespace branch April 28, 2025 07:57
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants