Skip to content

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #19638

Adds suggestions to the eqeqeq rule.

Is there anything you'd like reviewers to focus on?

No

@snitin315 snitin315 requested a review from a team as a code owner April 19, 2025 16:44
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 19, 2025
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Apr 19, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Apr 19, 2025
Copy link

netlify bot commented Apr 19, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 2e5be16
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/680ad29dc999fc0008f7c83e

@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Implementing in Triage Apr 20, 2025
@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 20, 2025
Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's docs says

The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

should we also update this para?

@snitin315
Copy link
Contributor Author

The para still holds true, but now we also give suggestions when we don't apply a fix.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for a second review.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Apr 25, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 0fa2b7a into main May 2, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage May 2, 2025
@fasttime fasttime deleted the feat/eqeqeq-suggestions branch May 2, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: add suggestions for eqeqeq
4 participants