feat: support TypeScript syntax in no-useless-constructor #19535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
19 tasks
snitin315
requested changes
Mar 19, 2025
| }); | ||
|
|
||
| ruleTesterTypeScript.run("no-useless-constructor", rule, { | ||
| valid: [ |
There was a problem hiding this comment.
Can we make sure to add all the test cases from here?
There was a problem hiding this comment.
I think I got all the ones that have TypeScript-specific keywords, and the existing ones cover the rest of the behavior. Is there anything missing between the two?
I am curious on this: should we include all tests in the TypeScript-specific ones? Just a bare minimum "smoke test" level? All the ones from the general JavaScript one as well?
There was a problem hiding this comment.
I meant all TS specific + some basic js because the parser is different. Also, can we add loc information assertions on errors?
snitin315
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Continues #19173.
Updates
no-useless-constructorto account for TypeScript syntax as handled in the@typescript-eslint/no-useless-constructorextension rule:protected/private(i.e. marking a constructor as non-public)publicconstructors when there is no superclassIs there anything you'd like reviewers to focus on?