feat: support TS syntax in `no-restricted-imports` #19562

snitin315 · 2025-03-22T20:48:47Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refers #19173

It adds support for type import syntaxes:

import type X from "..."
import { type X } from "..."
import x = require("...")

Is there anything you'd like reviewers to focus on?

https://typescript-eslint.io/rules/no-restricted-imports/

netlify · 2025-03-22T20:49:07Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`94d8d83`
🔍 Latest deploy log	https://app.netlify.com/projects/docs-eslint/deploys/6897451edffc820008d496c3

JoshuaKGoldberg

There seems to be either extra functionality or missing tests with allowedTypeImportPathNameSet / isAllowedTypeImportPath.

lib/rules/no-restricted-imports.js

JoshuaKGoldberg

I think we can actually get rid of a bunch of this extension code! 🔪

lib/rules/no-restricted-imports.js

snitin315 · 2025-04-09T06:24:08Z

@JoshuaKGoldberg This needs a re-review.

JoshuaKGoldberg

The core functionality looks perfect to me. Just requesting changes on docs (sorry for not till now) and a bit more tests. 🚀

lib/rules/no-restricted-imports.js

docs/src/rules/no-restricted-imports.md

mdjermanovic

Can you also update the types for this rule in lib/types/rules.d.ts?

lib/rules/no-restricted-imports.js

github-actions · 2025-04-24T22:35:35Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

snitin315 · 2025-05-03T08:18:51Z

@JoshuaKGoldberg @mdjermanovic I have addressed your feedback.

JoshuaKGoldberg

Looks great, nicely done! 👏

lib/rules/no-restricted-imports.js

github-actions · 2025-05-26T22:35:01Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

snitin315 · 2025-07-08T06:33:08Z

Apologies for the delay, will push an update & resolve the comments.

nzakas

Added some notes on the docs.

docs/src/rules/no-restricted-imports.md

Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>

lib/rules/no-restricted-imports.js

docs/src/rules/no-restricted-imports.md

lib/types/rules.d.ts

nzakas · 2025-07-24T15:45:40Z

@snitin315 can you check the CI failures?

lib/rules/no-restricted-imports.js

mdjermanovic · 2025-07-31T09:08:21Z

lib/rules/no-restricted-imports.js

+								// Skip if this is a type-only import specifier and type imports are allowed
+								if (
+									allowTypeImports &&
+									isTypeOnlySpecifier(specifier)


Suggested change

isTypeOnlySpecifier(specifier)

isTypeOnlySpecifier(specifier.specifier)

Seems that tests for this are missing as this wasn't caught.

lib/rules/no-restricted-imports.js

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

mdjermanovic · 2025-08-12T13:41:18Z

lib/rules/no-restricted-imports.js

+								if (allowTypeImports) {
+									return;
+								}


Suggested change

if (allowTypeImports) {

return;

}

if (

allowTypeImports &&

isTypeOnlySpecifier(specifier.specifier)

) {

return;

}

Looks like the isTypeOnlySpecifier() check has been removed instead of fixed (#19562 (comment)).

For example, this should not pass:

/* eslint no-restricted-imports: ["error", { paths: [{ name: "foo", allowImportNames: ["bar"], allowTypeImports: true }]}] */ import { baz } from "foo";

github-project-automation bot added this to Triage Mar 22, 2025

github-project-automation bot moved this to Needs Triage in Triage Mar 22, 2025

eslint-github-bot bot added the feature This change adds a new feature to ESLint label Mar 22, 2025

github-actions bot added the rule Relates to ESLint's core rules label Mar 22, 2025

snitin315 mentioned this pull request Mar 22, 2025

Change Request: Make rules TypeScript syntax-aware #19173

Open

19 tasks

snitin315 force-pushed the ts/no-restricted-imports branch from d4d142d to dffbc64 Compare March 26, 2025 15:27

snitin315 marked this pull request as ready for review March 26, 2025 15:38

snitin315 requested a review from a team as a code owner March 26, 2025 15:38

JoshuaKGoldberg requested changes Mar 27, 2025

View reviewed changes

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

nzakas moved this from Needs Triage to Implementing in Triage Mar 27, 2025

JoshuaKGoldberg requested changes Mar 31, 2025

View reviewed changes

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

JoshuaKGoldberg requested changes Apr 9, 2025

View reviewed changes

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

lib/rules/no-restricted-imports.js Show resolved Hide resolved

docs/src/rules/no-restricted-imports.md Outdated Show resolved Hide resolved

snitin315 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Apr 9, 2025

snitin315 requested a review from JoshuaKGoldberg April 10, 2025 01:56

mdjermanovic reviewed Apr 14, 2025

View reviewed changes

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

github-actions bot added Stale and removed Stale labels Apr 24, 2025

JoshuaKGoldberg previously approved these changes May 6, 2025

View reviewed changes

snitin315 moved this from Implementing to Second Review Needed in Triage May 11, 2025

snitin315 requested a review from mdjermanovic May 11, 2025 05:19

mdjermanovic reviewed May 16, 2025

View reviewed changes

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

mdjermanovic moved this from Second Review Needed to Implementing in Triage May 25, 2025

github-actions bot added the Stale label May 26, 2025

feat: support TS syntax in no-restricted-imports

a9558b8

github-actions bot removed the Stale label Jul 6, 2025

snitin315 mentioned this pull request Jul 8, 2025

feat: support TS syntax in no-restricted-imports #19915

Closed

1 task

snitin315 added 4 commits July 10, 2025 12:36

fix: correct false positives

59711ed

docs: add more examples

5cbc701

Merge branch 'main' into ts/no-restricted-imports

8a9d82a

chore: fix formatting

375f2d0

nzakas reviewed Jul 10, 2025

View reviewed changes

docs/src/rules/no-restricted-imports.md Outdated Show resolved Hide resolved

docs/src/rules/no-restricted-imports.md Outdated Show resolved Hide resolved

docs/src/rules/no-restricted-imports.md Outdated Show resolved Hide resolved

snitin315 and others added 4 commits July 17, 2025 11:02

docs: apply suggestions from code review

5e5969c

Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>

docs: udpate description

e9545c4

chore: fix formatting

11f12be

Merge branch 'main' into ts/no-restricted-imports

f0abb4f

mdjermanovic reviewed Jul 17, 2025

View reviewed changes

lib/rules/no-restricted-imports.js Outdated Show resolved Hide resolved

mdjermanovic reviewed Jul 17, 2025

View reviewed changes

snitin315 added 2 commits July 17, 2025 17:06

docs: update examples

0b3c504

fix: correct false positives

cccb7bb

mdjermanovic reviewed Jul 23, 2025

View reviewed changes

docs/src/rules/no-restricted-imports.md Outdated Show resolved Hide resolved

mdjermanovic reviewed Jul 23, 2025

View reviewed changes

lib/types/rules.d.ts Outdated Show resolved Hide resolved

snitin315 added 3 commits July 24, 2025 09:57

refactor: code & types

f31778d

refactor: types

d760448

Merge branch 'main' into ts/no-restricted-imports

c3b29cf

Merge branch 'main' into ts/no-restricted-imports

cd67608

mdjermanovic moved this from Evaluating to Implementing in Triage Jul 30, 2025

mdjermanovic reviewed Jul 31, 2025

View reviewed changes

snitin315 and others added 4 commits August 9, 2025 17:19

test: add more cases

460ebda

refactor: apply suggestions from code review

aa27ce8

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

test: cover more cases

2709278

refactor: code

94d8d83

mdjermanovic reviewed Aug 12, 2025

View reviewed changes

	isTypeOnlySpecifier(specifier)
	isTypeOnlySpecifier(specifier.specifier)

Uh oh!

feat: support TS syntax in no-restricted-imports #19562

Are you sure you want to change the base?

feat: support TS syntax in no-restricted-imports #19562

Uh oh!

Conversation

snitin315 commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

snitin315 commented Apr 9, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2025

Uh oh!

snitin315 commented May 3, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

snitin315 commented Jul 8, 2025

Uh oh!

nzakas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nzakas commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

snitin315 Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: support TS syntax in `no-restricted-imports` #19562

feat: support TS syntax in `no-restricted-imports` #19562

snitin315 commented Mar 22, 2025 •

edited

Loading

netlify bot commented Mar 22, 2025 •

edited

Loading