Skip to content

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Update Eleventy from v2 to v3

What changes did you make? (Give an overview)

Ref: eslint/eslint.org#644
similar to eslint/eslint.org#690
I updated Eleventy from v2 to v3, verified the dev server, and tried building the website. Everything worked fine.

Eleventy v2 Build time Eleventy v2 - Build time
Screenshot 2025-02-09 at 8 44 17 PM Screenshot 2025-02-09 at 8 26 20 PM

I didn't notice much difference in the build time.

Is there anything you'd like reviewers to focus on?

@amareshsm amareshsm requested a review from a team as a code owner February 9, 2025 15:25
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Feb 9, 2025
Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 5769e0f
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67a8c901f5409700088f0f6d
😎 Deploy Preview https://deploy-preview-19415--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I verified that the output in _site is same before and after this change.

Leaving open for a second review.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 10, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will leave open until after the patch release.

@nzakas nzakas merged commit 0636cab into main Feb 12, 2025
31 checks passed
@nzakas nzakas deleted the eleventy-v3 branch February 12, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants