chore: remove formatting-related lint rules internally #19473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
This was referenced Mar 10, 2025
nzakas
previously approved these changes
Mar 10, 2025
|
Sorry, found one last point I'd missed earlier: Anyway, I believe the three PRs are split up so that merging them sequentially won't cause failures in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: internal-only change
What changes did you make? (Give an overview)
Split out of #19354: removes all formatting-related lint rules from core. This way the
mainbranch will not be broken by adding in formatting-related configuration settings in a different PR from the formatting changes themselves. See #19354.Also updates
tools/update-rule-type-headers.js to print tabs, since printing spaces will cause a conflict once the Prettier settings from #19354 & #19355 are applied.Is there anything you'd like reviewers to focus on?
The intended merge order of PRs to avoid
mainbranch CI failures is:.git-blame-ignore-revs