fix: improve error message for falsy parsed JS AST #19458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
CI failures are external to this change. |
nzakas
reviewed
Feb 25, 2025
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
JoshuaKGoldberg
commented
Feb 28, 2025
| if (!ast.tokens) { | ||
| throw new Error("AST is missing the tokens array."); | ||
| throw new TypeError("AST is missing the tokens array."); |
There was a problem hiding this comment.
Following #19458 (comment), I went ahead and updated the rest of the error classes too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Adds an
iffor the case of a falsy AST inJS'sSourceCode>validatefunction.Uses a more generalized, succinct error message than what I originally suggested in the issue. I found this one to align more with the rest of them.
Is there anything you'd like reviewers to focus on?