Skip to content

Conversation

fasttime
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Add a test

fixes #19441

What changes did you make? (Give an overview)

Added a type test to ensure that #19441 is fixed.

The new test should pass once #19448 is merged.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit ea6e633
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67b87aa7982a8300083b2927

@fasttime fasttime added the types Related to TypeScript types label Feb 21, 2025
@fasttime fasttime marked this pull request as ready for review February 21, 2025 13:15
@fasttime fasttime requested a review from a team as a code owner February 21, 2025 13:15
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 3401b85 into main Feb 21, 2025
30 checks passed
@mdjermanovic mdjermanovic deleted the issue19441 branch February 21, 2025 13:55
@Jason3S
Copy link

Jason3S commented Feb 22, 2025

@fasttime,

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: Types are broken in 9.20.1
3 participants