Skip to content

chore: formatted files with Prettier via trunk fmt #19355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 19, 2025
Merged

chore: formatted files with Prettier via trunk fmt #19355

merged 19 commits into from
Mar 19, 2025

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 21, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: internal tooling change

Fixes #17814 (part 2 of 2).

What changes did you make? (Give an overview)

Builds on top of #19354 by additionally:

  1. 536c32c: running npx trunk fmt --all
  2. b8dfae7: Touching up comment directives that were broken by those formatting changes

The CodeQL reports are all for existing code so I dismissed them. This PR shouldn't change any behavior or impact users in any way. Any actual configuration changes should all be in #19354.

Is there anything you'd like reviewers to focus on?

When on the github dot com view, I would recommend viewing with Hide whitespace enabled.

The intended merge order of PRs to avoid main branch CI failures is:

  1. chore: remove formatting-related lint rules internally #19473: to remove any CI check that would fail on the upcoming new formatting
  2. 👉 chore: formatted files with Prettier via trunk fmt #19355 (this one): applies new formatting rules, and should be squash-merged to make a single commit for .git-blame-ignore-revs
  3. chore: enabled Prettier in Trunk #19354: adds Prettier checks in CI and as commit hooks via Trunk

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jan 21, 2025
@github-actions github-actions bot added rule Relates to ESLint's core rules cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features formatter Relates to the formatters bundled with ESLint github actions labels Jan 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 01a9d58
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67dadbdd6c70460008a0fd0c

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 21, 2025
Merged
1 task
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 21, 2025
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2025
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 31, 2025 21:54
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner January 31, 2025 21:54
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: apply Prettier formatting chore: formatted files with Prettier via trunk fmt Jan 31, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 31, 2025
Closed
1 task
@github-actions GitHub Actions
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Feb 10, 2025
@fasttime fasttime removed the Stale label Feb 11, 2025
@nzakas
Copy link
Member

nzakas commented Feb 11, 2025

@fasttime reminder that when you remove the "stale" issue also leave a comment explaining why this isn't stale.

@fasttime
Copy link
Member

@fasttime reminder that when you remove the "stale" issue also leave a comment explaining why this isn't stale.

My bad, sorry. This is still a work in progress with an ongoing discussion in #19354.

@github-actions GitHub Actions
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Feb 22, 2025
@nzakas
Copy link
Member

nzakas commented Feb 25, 2025

Ping @JoshuaKGoldberg

@github-actions github-actions bot removed the Stale label Feb 25, 2025
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft March 7, 2025 20:57
@JoshuaKGoldberg
Copy link
Contributor Author

The second half of the day Tuesday (tomorrow) and the first half of Wednesday I'm fully clear (all EST).

@nzakas
Copy link
Member

nzakas commented Mar 17, 2025

Okay, let me see if I can get in touch with everyone to coordinate.

@nzakas
Copy link
Member

nzakas commented Mar 18, 2025

Let's do Wednesday, March 19, at 10am EDT?

When you start, please post in Discord and add a comment to each open PR not to merge until you give the all-clear. And when completed, also post in Discord and on the PRs.

I should be online around that time barring unexpected circumstances.

This was referenced Mar 19, 2025
Closed
Merged
Merged
Merged
Merged
Merged
Merged
@fisker
Copy link
Contributor

fisker commented Mar 19, 2025

Reminder: we should probably add .git-blame-ignore-revs after this gets merged to ignore this commit.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 19, 2025
Merged
fisker
fisker reviewed Mar 19, 2025
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg merged commit 129882d into eslint:main Mar 19, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Mar 19, 2025
@JoshuaKGoldberg JoshuaKGoldberg deleted the prettier-formatted branch March 19, 2025 15:19
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 19, 2025
Merged
1 task
@fisker
Copy link
Contributor

fisker commented Mar 19, 2025

Great work!

@fasttime fasttime mentioned this pull request Mar 19, 2025
Merged
1 task
@fisker

This comment was marked as outdated.

Sign in to view
@fisker
Copy link
Contributor

fisker commented Mar 28, 2025

Also, is it a typo on this line?

eslint/package.json

Line 61 in 46eea6d

"lint:fix:docs:js": "trunk check -y --ignore=** --ignore=!docs/**/*.js -a --flter=eslint && trunk check -y --ignore=** --ignore=!docs/**/*.js", 

- --flter
+ --filter

JoshuaKGoldberg added a commit that referenced this pull request Mar 31, 2025
@JoshuaKGoldberg
chore: correct 'flter'/'filter' typo in package script
058d3fe 
#19355 (comment)

Co-authored-by: @fisker
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 31, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

+1 more reviewer

@fisker fisker fisker left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore This change is not user-facing cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features formatter Relates to the formatters bundled with ESLint github actions rule Relates to ESLint's core rules
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Request: Consider adopting prettier internally
4 participants
@JoshuaKGoldberg @nzakas @fasttime @fisker