Skip to content

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Nov 28, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

I’ve switched the word order in no-unreachable.md for consistency.

The documentation consistently uses the order return, throw, continue, and break, as shown in the screenshot below. However, the sentence I modified was not following this pattern.

image

image

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir requested a review from a team as a code owner November 28, 2024 11:17
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Nov 28, 2024
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit a2c2170
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6748515854e6be000823e579
😎 Deploy Preview https://deploy-preview-19189--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 28, 2024
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@mdjermanovic mdjermanovic changed the title docs: switch the order of words in no-unreachable.md docs: switch the order of words in no-unreachable Nov 28, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 0c8cea8 into eslint:main Nov 28, 2024
27 checks passed
@lumirlumir lumirlumir deleted the docs-switch-order-no-unreachable branch November 28, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants