✅ Deploy Preview for docs-eslint canceled.

@softius thanks for getting this started. As a note: we don't review draft PRs, so when you're ready for feedback, go ahead and click "Ready for review".

@nzakas is there a way to rerun the failing check for the browser tests? It doesn't seem related to this PR.

@softius the browser test is failing most of the times, that's not a problem with your PR. Please, disregard failures in that test until the problem is fixed.

@nzakas @fasttime apart from the changes discussed in the related at the RFC, I did the following changes:

1. When there are unused suppressions left, the errors are displayed (if any) before displaying the message about pruning.
2. --fix automatically prunes the suppressions file (if any)
3. Apart from errorCount the fatalErrorCount, fixableErrorCount, warningCount and fixableWarningCount are also adjusted.

Point 3 is an overkill and error prone, I would prefer to export calculateStatsPerFile and re-use it in SuppressedViolationsManager for consistency, if that makes sense.

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

Sorry for the late reply.

@nzakas @fasttime apart from the changes discussed in the related at the RFC, I did the following changes:

1. When there are unused suppressions left, the errors are displayed (if any) before displaying the message about pruning.

I agree it makes sense to display the message about pruning after the formatter output.

2. --fix automatically prunes the suppressions file (if any)

Not sure if this is necessary. If the fixes and the unused suppressions belong to different rules or different files, it's probably better to handle them separately.

3. Apart from errorCount the fatalErrorCount, fixableErrorCount, warningCount and fixableWarningCount are also adjusted.

Point 3 is an overkill and error prone, I would prefer to export calculateStatsPerFile and re-use it in SuppressedViolationsManager for consistency, if that makes sense.

All counts need to be all adjusted. It's fine to export calculateStatsPerFile from eslint.js or extract it into a shared module and export it from there, as long as it's not exposed from the public API.

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

Really nice work on all of this. I left a few comments throughout, mostly for a bit of cleanup and aligning with the project standards.

Thank you @nzakas ! I went through your feedback and adjusted accordingly. Everything should be there now, please advise otherwise.

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

Not stale. This is pending a review.

@eslint/eslint-tsc would appreciate some more reviews on this.

@trickpattyFH20 the scope of this PR is closed. If you have suggestions for how to improve things, please open a separate issue.

Regarding VS Code - right now, this is a CLI-only feature, and that's okay. It's a big feature that we need to land and get feedback on before we start thinking through additional use cases. (Again, feel free to open an issue about this. Keep in mind that we don't actually maintain the ESLint VS Code extension, though, so our role would be to ensure access to this feature via some API.)

Nice work @softius! Would you be interested in writing an introductory blog post for the ESLint blog about this feature? We can publish it along with the next release.

@nzakas absolutely! Please point me to the right direction and I will prepare the blog. Is this for "News and Updates" section?

Yes. Check out the README here:
https://github.com/eslint/eslint.org/tree/main/src/content/drafts