Skip to content

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Aug 31, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #18712

What changes did you make? (Give an overview)

Adds a requireFlag option. Can be set to "u" or "v" to require use of a particular Unicode flag.

Is there anything you'd like reviewers to focus on?

No.

@brettz9 brettz9 requested a review from a team as a code owner August 31, 2024 12:04
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Aug 31, 2024
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Aug 31, 2024
Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 978e563
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66d6b32f89341f00085298bf
😎 Deploy Preview https://deploy-preview-18836--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 1, 2024
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@mdjermanovic mdjermanovic changed the title feat: requireFlag option feat: add requireFlag option to require-unicode-regexp rule Sep 1, 2024
brettz9 and others added 11 commits September 2, 2024 04:44
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
…escapes or template literal with no expressions and no escapes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: require-v-flag boolean option in require-unicode-regexp
4 participants