feat: limit namespace import identifier in id-length rule #18849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JoshuaKGoldberg
requested changes
Sep 3, 2024
|
Moving to "Blocked" as we need to get the issue accepted first. |
|
The issue has been accepted so moving out of "Blocked" |
Tanujkanti4441
requested changes
Sep 5, 2024
Co-authored-by: Tanuj Kanti <86398394+Tanujkanti4441@users.noreply.github.com>
Co-authored-by: Tanuj Kanti <86398394+Tanujkanti4441@users.noreply.github.com>
Co-authored-by: Tanuj Kanti <86398394+Tanujkanti4441@users.noreply.github.com>
|
@Tanujkanti4441 |
Tanujkanti4441
requested changes
Sep 5, 2024
…default 2 and with max option
Tanujkanti4441
approved these changes
Sep 5, 2024
1 task
mdjermanovic
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @JoshuaKGoldberg to verify his review suggestions.
This was referenced Sep 29, 2024
This was referenced Oct 2, 2024
This was referenced Oct 26, 2024
This was referenced Oct 28, 2024
This was referenced Oct 29, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
limit namespace import identifier in id-length rule.
I did it because of the Issue #18847
Is there anything you'd like reviewers to focus on?
No i don't.
This is my first open-source activity, If i missed something notice me please.
Thank you for all of your effort in eslint.
Thanks