feat: report duplicate allowed flags in `no-invalid-regexp` #18754

Tanujkanti4441 · 2024-08-05T17:00:33Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

no-invalid-regexp rule doesn't report duplicate flags that are allowed by the allowConstructorFlags option.

/*eslint no-invalid-regexp: ["error", { "allowConstructorFlags": ["a"] }]*/

new RegExp('.', 'aa'); // not reported

made the rule to report these flags

Is there anything you'd like reviewers to focus on?

Fixes #18748

netlify · 2024-08-05T17:00:49Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`761c148`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/66d1e622cc1208000840a7e7

lib/rules/no-invalid-regexp.js

tests/lib/rules/no-invalid-regexp.js

aladdin-add

LGTM. Would like another review before merging.

Tanujkanti4441 · 2024-08-06T06:02:11Z

@aladdin-add, right now it is allowed to pass duplicate strings to allowConstructorFlags which can also lead to allow duplicate flags in regex constructor i think this should also be fixed or is it intentional?

aladdin-add · 2024-08-06T06:13:45Z

IMHO, it seems a bug - I didn't see it's covered by the tests. it can be easily fixed by adding uniqueItems: true, however it's a breaking change, so we have to wait until eslint v10. Can you create another issue?

Tanujkanti4441 · 2024-08-06T06:26:36Z

IMHO, it seems a bug - I didn't see it's covered by the tests. it can be easily fixed by adding uniqueItems: true, however it's a breaking change, so we have to wait until eslint v10. Can you create another issue?

have created the issue => #18755

tests/lib/rules/no-invalid-regexp.js

lib/rules/no-invalid-regexp.js

tests/lib/rules/no-invalid-regexp.js

mdjermanovic · 2024-08-22T08:47:06Z

I changed the tag to feat because this produces more lint errors.

tests/lib/rules/no-invalid-regexp.js

fasttime

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`9.8.0` -> `9.10.0`](https://renovatebot.com/diffs/npm/eslint/9.8.0/9.10.0) | | [@types/eslint](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/eslint) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/eslint)) | devDependencies | patch | [`9.6.0` -> `9.6.1`](https://renovatebot.com/diffs/npm/@types%2feslint/9.6.0/9.6.1) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v9.10.0`](https://github.com/eslint/eslint/releases/tag/v9.10.0) [Compare Source](eslint/eslint@v9.9.1...v9.10.0) #### Features - [`301b90d`](eslint/eslint@301b90d) feat: Add types ([#18854](eslint/eslint#18854)) (Nicholas C. Zakas) - [`bcf0df5`](eslint/eslint@bcf0df5) feat: limit namespace import identifier in id-length rule ([#18849](eslint/eslint#18849)) (ChaedongIm) - [`45c18e1`](eslint/eslint@45c18e1) feat: add `requireFlag` option to `require-unicode-regexp` rule ([#18836](eslint/eslint#18836)) (Brett Zamir) - [`183b459`](eslint/eslint@183b459) feat: add error message for duplicate flags in `no-invalid-regexp` ([#18837](eslint/eslint#18837)) (Tanuj Kanti) - [`c69b406`](eslint/eslint@c69b406) feat: report duplicate allowed flags in `no-invalid-regexp` ([#18754](eslint/eslint#18754)) (Tanuj Kanti) #### Documentation - [`bee0e7a`](eslint/eslint@bee0e7a) docs: update README ([#18865](eslint/eslint#18865)) (Milos Djermanovic) - [`5d80b59`](eslint/eslint@5d80b59) docs: specify that `ruleId` can be `null` in custom formatter docs ([#18857](eslint/eslint#18857)) (Milos Djermanovic) - [`156b1c3`](eslint/eslint@156b1c3) docs: Update README (GitHub Actions Bot) - [`f6fdef9`](eslint/eslint@f6fdef9) docs: Update README (GitHub Actions Bot) - [`a20c870`](eslint/eslint@a20c870) docs: Update README (GitHub Actions Bot) - [`90e699b`](eslint/eslint@90e699b) docs: Update README (GitHub Actions Bot) #### Chores - [`24c3ff7`](eslint/eslint@24c3ff7) chore: upgrade to [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).10.0 ([#18866](eslint/eslint#18866)) (Francesco Trotta) - [`1ebdde1`](eslint/eslint@1ebdde1) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e8fc5bd`](eslint/eslint@e8fc5bd) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.5.0 ([#18848](eslint/eslint#18848)) (renovate\[bot]) - [`343f992`](eslint/eslint@343f992) refactor: don't use `node.value` when removing unused directives ([#18835](eslint/eslint#18835)) (Milos Djermanovic) - [`3db18b0`](eslint/eslint@3db18b0) refactor: Extract FileContext into class ([#18831](eslint/eslint#18831)) (Nicholas C. Zakas) - [`931d650`](eslint/eslint@931d650) refactor: Use [@eslint/plugin-kit](https://github.com/eslint/plugin-kit) ([#18822](eslint/eslint#18822)) (Nicholas C. Zakas) - [`ed5cf0c`](eslint/eslint@ed5cf0c) chore: update dependency [@eslint/json](https://github.com/eslint/json) to ^0.4.0 ([#18829](eslint/eslint#18829)) (Milos Djermanovic) - [`d1f0831`](eslint/eslint@d1f0831) chore: added missing ids ([#18817](eslint/eslint#18817)) (Strek) - [`ec92813`](eslint/eslint@ec92813) refactor: Config class ([#18763](eslint/eslint#18763)) (Nicholas C. Zakas) ### [`v9.9.1`](https://github.com/eslint/eslint/releases/tag/v9.9.1) [Compare Source](eslint/eslint@v9.9.0...v9.9.1) #### Bug Fixes - [`9bde90c`](eslint/eslint@9bde90c) fix: add logic to handle `fixTypes` in `lintText()` ([#18736](eslint/eslint#18736)) (Amaresh S M) #### Documentation - [`4840930`](eslint/eslint@4840930) docs: Update README with version support and clean up content ([#18804](eslint/eslint#18804)) (Nicholas C. Zakas) - [`f61f40d`](eslint/eslint@f61f40d) docs: Update globals examples ([#18805](eslint/eslint#18805)) (Nicholas C. Zakas) - [`241fcea`](eslint/eslint@241fcea) docs: Use and define languages ([#18795](eslint/eslint#18795)) (Nicholas C. Zakas) - [`5dbdd63`](eslint/eslint@5dbdd63) docs: eslint-plugin-markdown -> [@eslint/markdown](https://github.com/eslint/markdown) ([#18797](eslint/eslint#18797)) (Nicholas C. Zakas) - [`c6c8ddd`](eslint/eslint@c6c8ddd) docs: update links to eslint-visitor-keys repo ([#18796](eslint/eslint#18796)) (Francesco Trotta) - [`f981d05`](eslint/eslint@f981d05) docs: Update README (GitHub Actions Bot) - [`b516974`](eslint/eslint@b516974) docs: update links to `eslint/js` repo ([#18781](eslint/eslint#18781)) (Francesco Trotta) - [`fb7a3f5`](eslint/eslint@fb7a3f5) docs: update note for package managers ([#18779](eslint/eslint#18779)) (Jay) #### Chores - [`b0c34d0`](eslint/eslint@b0c34d0) chore: upgrade to [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).9.1 ([#18809](eslint/eslint#18809)) (Francesco Trotta) - [`cd5a0da`](eslint/eslint@cd5a0da) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e112642`](eslint/eslint@e112642) refactor: Extract parsing logic from Linter ([#18790](eslint/eslint#18790)) (Nicholas C. Zakas) - [`0f68a85`](eslint/eslint@0f68a85) chore: use eslint-plugin-yml on yaml files only ([#18801](eslint/eslint#18801)) (Milos Djermanovic) - [`f8d1b3c`](eslint/eslint@f8d1b3c) chore: update dependencies for browser tests ([#18794](eslint/eslint#18794)) (Christian Bromann) - [`aed2624`](eslint/eslint@aed2624) chore: update dependency [@eslint/config-array](https://github.com/eslint/config-array) to ^0.18.0 ([#18788](eslint/eslint#18788)) (renovate\[bot]) - [`5c29128`](eslint/eslint@5c29128) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.4.0 ([#18789](eslint/eslint#18789)) (renovate\[bot]) - [`5d66fb2`](eslint/eslint@5d66fb2) chore: migrate linting workflow to use trunk check meta-linter ([#18643](eslint/eslint#18643)) (Chris Clearwater) - [`bf96855`](eslint/eslint@bf96855) chore: add ids to github issue templates ([#18775](eslint/eslint#18775)) (Strek) ### [`v9.9.0`](https://github.com/eslint/eslint/releases/tag/v9.9.0) [Compare Source](eslint/eslint@v9.8.0...v9.9.0) #### Features - [`41d0206`](eslint/eslint@41d0206) feat: Add support for TS config files ([#18134](eslint/eslint#18134)) (Arya Emami) - [`3a4eaf9`](eslint/eslint@3a4eaf9) feat: add suggestion to `require-await` to remove `async` keyword ([#18716](eslint/eslint#18716)) (Dave) #### Documentation - [`9fe068c`](eslint/eslint@9fe068c) docs: how to author plugins with configs that extend other configs ([#18753](eslint/eslint#18753)) (Alec Gibson) - [`48117b2`](eslint/eslint@48117b2) docs: add version support page in the side navbar ([#18738](eslint/eslint#18738)) (Amaresh S M) - [`fec2951`](eslint/eslint@fec2951) docs: add version support page to the dropdown ([#18730](eslint/eslint#18730)) (Amaresh S M) - [`38a0661`](eslint/eslint@38a0661) docs: Fix typo ([#18735](eslint/eslint#18735)) (Zaina Al Habash) - [`3c32a9e`](eslint/eslint@3c32a9e) docs: Update yarn command for creating ESLint config ([#18739](eslint/eslint#18739)) (Temitope Ogunleye) - [`f9ac978`](eslint/eslint@f9ac978) docs: Update README (GitHub Actions Bot) #### Chores - [`461b2c3`](eslint/eslint@461b2c3) chore: upgrade to `@eslint/js@9.9.0` ([#18765](eslint/eslint#18765)) (Francesco Trotta) - [`59dba1b`](eslint/eslint@59dba1b) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`fea8563`](eslint/eslint@fea8563) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.3.0 ([#18724](eslint/eslint#18724)) (renovate\[bot]) - [`aac191e`](eslint/eslint@aac191e) chore: update dependency [@eslint/json](https://github.com/eslint/json) to ^0.3.0 ([#18760](eslint/eslint#18760)) (renovate\[bot]) - [`b97fa05`](eslint/eslint@b97fa05) chore: update wdio dependencies for more stable tests ([#18759](eslint/eslint#18759)) (Christian Bromann) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/215 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@eslint/js](https://eslint.org) ([source](https://github.com/eslint/eslint/tree/HEAD/packages/js)) | devDependencies | minor | [`9.9.1` -> `9.10.0`](https://renovatebot.com/diffs/npm/@eslint%2fjs/9.9.1/9.10.0) | --- ### Release Notes <details> <summary>eslint/eslint (@eslint/js)</summary> ### [`v9.10.0`](https://github.com/eslint/eslint/releases/tag/v9.10.0) [Compare Source](eslint/eslint@v9.9.1...v9.10.0) #### Features - [`301b90d`](eslint/eslint@301b90d) feat: Add types ([#18854](eslint/eslint#18854)) (Nicholas C. Zakas) - [`bcf0df5`](eslint/eslint@bcf0df5) feat: limit namespace import identifier in id-length rule ([#18849](eslint/eslint#18849)) (ChaedongIm) - [`45c18e1`](eslint/eslint@45c18e1) feat: add `requireFlag` option to `require-unicode-regexp` rule ([#18836](eslint/eslint#18836)) (Brett Zamir) - [`183b459`](eslint/eslint@183b459) feat: add error message for duplicate flags in `no-invalid-regexp` ([#18837](eslint/eslint#18837)) (Tanuj Kanti) - [`c69b406`](eslint/eslint@c69b406) feat: report duplicate allowed flags in `no-invalid-regexp` ([#18754](eslint/eslint#18754)) (Tanuj Kanti) #### Documentation - [`bee0e7a`](eslint/eslint@bee0e7a) docs: update README ([#18865](eslint/eslint#18865)) (Milos Djermanovic) - [`5d80b59`](eslint/eslint@5d80b59) docs: specify that `ruleId` can be `null` in custom formatter docs ([#18857](eslint/eslint#18857)) (Milos Djermanovic) - [`156b1c3`](eslint/eslint@156b1c3) docs: Update README (GitHub Actions Bot) - [`f6fdef9`](eslint/eslint@f6fdef9) docs: Update README (GitHub Actions Bot) - [`a20c870`](eslint/eslint@a20c870) docs: Update README (GitHub Actions Bot) - [`90e699b`](eslint/eslint@90e699b) docs: Update README (GitHub Actions Bot) #### Chores - [`24c3ff7`](eslint/eslint@24c3ff7) chore: upgrade to [@eslint/js](https://github.com/eslint/js)[@9](https://github.com/9).10.0 ([#18866](eslint/eslint#18866)) (Francesco Trotta) - [`1ebdde1`](eslint/eslint@1ebdde1) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (Jenkins) - [`e8fc5bd`](eslint/eslint@e8fc5bd) chore: update dependency [@eslint/core](https://github.com/eslint/core) to ^0.5.0 ([#18848](eslint/eslint#18848)) (renovate\[bot]) - [`343f992`](eslint/eslint@343f992) refactor: don't use `node.value` when removing unused directives ([#18835](eslint/eslint#18835)) (Milos Djermanovic) - [`3db18b0`](eslint/eslint@3db18b0) refactor: Extract FileContext into class ([#18831](eslint/eslint#18831)) (Nicholas C. Zakas) - [`931d650`](eslint/eslint@931d650) refactor: Use [@eslint/plugin-kit](https://github.com/eslint/plugin-kit) ([#18822](eslint/eslint#18822)) (Nicholas C. Zakas) - [`ed5cf0c`](eslint/eslint@ed5cf0c) chore: update dependency [@eslint/json](https://github.com/eslint/json) to ^0.4.0 ([#18829](eslint/eslint#18829)) (Milos Djermanovic) - [`d1f0831`](eslint/eslint@d1f0831) chore: added missing ids ([#18817](eslint/eslint#18817)) (Strek) - [`ec92813`](eslint/eslint@ec92813) refactor: Config class ([#18763](eslint/eslint#18763)) (Nicholas C. Zakas) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/226 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

fix: duplicate allowed flags

5c0a46b

Tanujkanti4441 requested a review from a team as a code owner August 5, 2024 17:00

eslint-github-bot bot added the bug ESLint is working incorrectly label Aug 5, 2024

github-actions bot added the rule Relates to ESLint's core rules label Aug 5, 2024

amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 5, 2024

aladdin-add reviewed Aug 6, 2024

View reviewed changes

lib/rules/no-invalid-regexp.js Outdated Show resolved Hide resolved

aladdin-add reviewed Aug 6, 2024

View reviewed changes

tests/lib/rules/no-invalid-regexp.js Show resolved Hide resolved

apply suggestions

00dd406

aladdin-add previously approved these changes Aug 6, 2024

View reviewed changes

fasttime reviewed Aug 6, 2024

View reviewed changes

tests/lib/rules/no-invalid-regexp.js Outdated Show resolved Hide resolved

fasttime reviewed Aug 8, 2024

View reviewed changes

lib/rules/no-invalid-regexp.js Outdated Show resolved Hide resolved

fix: error message

2098a40

Tanujkanti4441 dismissed aladdin-add’s stale review via 2098a40 August 9, 2024 12:14

fasttime reviewed Aug 12, 2024

View reviewed changes

tests/lib/rules/no-invalid-regexp.js Outdated Show resolved Hide resolved

mdjermanovic changed the title ~~fix: duplicate allowed flags in no-invalid-regexp~~ feat: report duplicate allowed flags in no-invalid-regexp Aug 22, 2024

eslint-github-bot bot added the feature This change adds a new feature to ESLint label Aug 22, 2024

keep duplicate flags in error message

a59ef60

fasttime reviewed Aug 30, 2024

View reviewed changes

tests/lib/rules/no-invalid-regexp.js Show resolved Hide resolved

apply suggestion

761c148

fasttime approved these changes Aug 31, 2024

View reviewed changes

fasttime merged commit c69b406 into eslint:main Aug 31, 2024
19 checks passed

Tanujkanti4441 deleted the fix-flag branch August 31, 2024 09:58

ekmixon mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint from 6.8.0 to 9.10.0 ekmixon/aquasecurity-cloudsploit#147

Open

This was referenced Sep 29, 2024

[Snyk] Upgrade @eslint/js from 9.3.0 to 9.10.0 tygyh/godot#3

Merged

[Snyk] Upgrade eslint from 9.3.0 to 9.10.0 tygyh/godot#4

Closed

Loonz206 mentioned this pull request Sep 30, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.10.0 Loonz206/todoredux#345

Merged

lholmquist mentioned this pull request Oct 1, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#233

Closed

tygyh mentioned this pull request Oct 2, 2024

[Snyk] Upgrade eslint from 9.3.0 to 9.10.0 tygyh/godot#6

Closed

This was referenced Oct 2, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#234

Closed

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#235

Closed

ebiz-markusrissmann mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.10.0 MarkusRissmann-private/githubclient#174

Open

qdraw mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.10.0 qdraw/starsky#1748

Closed

lholmquist mentioned this pull request Oct 5, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#236

Closed

Loonz206 mentioned this pull request Oct 16, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.11.1 Loonz206/todoredux#349

Merged

This was referenced Oct 28, 2024

[Snyk] Upgrade eslint from 9.3.0 to 9.12.0 tygyh/godot#11

Closed

[Snyk] Upgrade @eslint/js from 9.10.0 to 9.12.0 tygyh/godot#12

Closed

lholmquist mentioned this pull request Oct 28, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.12.0 nodeshift/kube-service-bindings#241

Closed

ekmixon mentioned this pull request Oct 28, 2024

[Snyk] Upgrade eslint from 6.8.0 to 9.12.0 ekmixon/aquasecurity-cloudsploit#150

Open

This was referenced Oct 29, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.12.0 nerdy-tech-com-gitub/images#7

Open

[Snyk] Upgrade eslint from 6.8.0 to 9.12.0 nerdy-tech-com-gitub/foreman#2

Open

Loonz206 mentioned this pull request Oct 30, 2024

[Snyk] Upgrade eslint from 9.9.1 to 9.12.0 Loonz206/todoredux#355

Open

This was referenced Oct 30, 2024

[Snyk] Upgrade eslint from 8.51.0 to 9.12.0 nodeshift/opossum#899

Closed

[Snyk] Upgrade eslint from 8.46.0 to 9.12.0 nodeshift/faas-js-runtime#369

Closed

zntb mentioned this pull request Nov 1, 2024

[Snyk] Upgrade eslint from 9.10.0 to 9.12.0 zntb/nextjs-template#70

Closed

lholmquist mentioned this pull request Nov 4, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.12.0 nodeshift/kube-service-bindings#244

Closed

sahilbhelkar mentioned this pull request Nov 5, 2024

[Snyk] Upgrade eslint from 9.0.0 to 9.12.0 sahilbhelkar/space#4

Open

nerdy-tech-com-gitub mentioned this pull request Nov 10, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.13.0 nerdy-tech-com-gitub/tailwindcss#7

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: report duplicate allowed flags in `no-invalid-regexp` #18754

feat: report duplicate allowed flags in `no-invalid-regexp` #18754

Uh oh!

Tanujkanti4441 commented Aug 5, 2024

Uh oh!

netlify bot commented Aug 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

aladdin-add left a comment

Uh oh!

Tanujkanti4441 commented Aug 6, 2024

Uh oh!

aladdin-add commented Aug 6, 2024

Uh oh!

Tanujkanti4441 commented Aug 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic commented Aug 22, 2024

Uh oh!

Uh oh!

fasttime left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: report duplicate allowed flags in no-invalid-regexp #18754

feat: report duplicate allowed flags in no-invalid-regexp #18754

Uh oh!

Conversation

Tanujkanti4441 commented Aug 5, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

Uh oh!

Uh oh!

aladdin-add left a comment

Choose a reason for hiding this comment

Uh oh!

Tanujkanti4441 commented Aug 6, 2024

Uh oh!

aladdin-add commented Aug 6, 2024

Uh oh!

Tanujkanti4441 commented Aug 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic commented Aug 22, 2024

Uh oh!

Uh oh!

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: report duplicate allowed flags in `no-invalid-regexp` #18754

feat: report duplicate allowed flags in `no-invalid-regexp` #18754

netlify bot commented Aug 5, 2024 •

edited

Loading