Skip to content

Conversation

snitin315
Copy link
Contributor

@snitin315 snitin315 commented Jun 10, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Refers #17225

#17020 (comment)

Is there anything you'd like reviewers to focus on?

No

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but I'm not sure if this should rather have been submitted by the original author of da8d52a (contributor) so I'd like @nzakas to verify.

@mdjermanovic mdjermanovic requested a review from nzakas June 12, 2023 09:26
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a small enough change that I think it's fine to merge.

@nzakas nzakas merged commit 8e51ea9 into main Jun 12, 2023
@nzakas nzakas deleted the docs/no-new-port branch June 12, 2023 18:02
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 10, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants