Skip to content

docs: stylelint enable no-duplicate-selectors #16467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: stylelint enable no-duplicate-selectors #16467

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Enabled the rule to flag when the calculated selector is duplicated in a stylesheet. Manually addressed flagged issues, as this one isn't auto-fixable

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Oct 29, 2022
@eslint-github-bot
Copy link

Hi @nschonni!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@netlify
Copy link

netlify bot commented Oct 29, 2022 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 0a61314
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/635cc304c6311b00090d8a86

@nschonni nschonni force-pushed the no-duplicate-selectors branch from 1d9661d to 0a61314 Compare October 29, 2022 06:06
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Oct 29, 2022
@nschonni nschonni changed the title doc: stylelint enable no-duplicate-selectors docs: stylelint enable no-duplicate-selectors Oct 29, 2022
snitin315
snitin315 approved these changes Oct 29, 2022
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm 👍🏻 to enable this rule.

@snitin315 snitin315 added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Oct 29, 2022
@harish-sethuraman harish-sethuraman mentioned this pull request Nov 4, 2022
Closed
@github-actions
Copy link

Oops! It looks like we lost track of this pull request. What do we want to do here? This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Dec 28, 2022
kecrily
kecrily approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want someone to double-check

@kecrily kecrily requested a review from a team December 29, 2022 06:23
@kecrily kecrily removed the Stale label Dec 29, 2022
@harish-sethuraman
Copy link
Member

I have the same doubt as well 😅 eslint/eslint.org#365 (review)

@nzakas
Copy link
Member

nzakas commented Jan 3, 2023

Everyone - what do we want to do here? Should we merge or close?

@harish-sethuraman
Copy link
Member

We might want to cross verify the changes and check if cascading is working properly alone. Nothing else is pending here.

@nzakas
Copy link
Member

nzakas commented Feb 13, 2023

Following up again...next steps?

@harish-sethuraman
Copy link
Member

Im closing this right now but re open once I sort this out. Im not getting time :(

@harish-sethuraman harish-sethuraman mentioned this pull request Mar 21, 2023
Merged
1 task
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Aug 14, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kecrily kecrily kecrily approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nschonni @harish-sethuraman @nzakas @kecrily @snitin315