Fix: ignore aligning single line in key-spacing (fixes #11414) #12652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
suggested changes
Dec 10, 2019
kaicataldo
approved these changes
Dec 14, 2019
There was a problem hiding this comment.
I'm not sure this fixes the problem in full (see comments). That being said, I recognize that the behavior I'm suggesting below is a lot more work. I would be fine with landing this as-is because it's passing through the options and does seem like an improvement 👍
| output: [ | ||
| "var obj = {", | ||
| " foo : 1,", | ||
| " 'bar' : 2, baz : 3, longlonglong: 4", |
There was a problem hiding this comment.
I understand why this is the way it is, but I wonder if this actually makes sense?
Feels like it should be:
var obj = {
foo : 1,
'bar': 2, baz: 3, longlonglong: 4
};
or
var obj = {
foo: 1, 'bar' : 2,
baz: 3, longlonglong: 4
};
| output: [ | ||
| "var obj = {", | ||
| " foo : 1,", | ||
| " 'bar' : 2, baz : 3,", |
There was a problem hiding this comment.
@kaicataldo
Yes, I agree :) Can I work on that in different PR?.
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fix #11414
make it ignore aligning single line properties.
Is there anything you'd like reviewers to focus on?