Skip to content

Fix: unexpected autofix in prefer-const (fixes #12514) #12521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fix: unexpected autofix in prefer-const (fixes #12514) #12521

merged 1 commit into from
Nov 4, 2019

Conversation

yeonjuan
Copy link
Member

@yeonjuan yeonjuan commented Nov 2, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

add id checking

Is there anything you'd like reviewers to focus on?
#12514

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Nov 2, 2019
@g-plane g-plane added accepted There is consensus among the team that this change meets the criteria for inclusion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Nov 2, 2019
g-plane
g-plane approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaicataldo
Copy link
Member

Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit ac60621 into eslint:master Nov 4, 2019
@snyk-bot snyk-bot mentioned this pull request Dec 1, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 11, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 11, 2020
Merged
Open
This was referenced Mar 26, 2020
Merged
Merged
Merged
Open
This was referenced Apr 3, 2020
Merged
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 4, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@g-plane g-plane g-plane approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion autofix This change is related to ESLint's autofixing capabilities bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeonjuan @kaicataldo @ilyavolodin @g-plane