Skip to content

Update: add a fixer for certain statically-verifiable eqeqeq cases #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2016
Merged

Update: add a fixer for certain statically-verifiable eqeqeq cases #7389

merged 2 commits into from
Nov 1, 2016

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[x] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This adds a fixer for certain specific cases of eqeqeq.

/* eslint eqeqeq: 2 */

typeof foo == 'bar'
1 == 1

// gets fixed to:

typeof foo === 'bar'
1 === 1

Only cases that can be statically verified to be the same type are fixed. (This uses the same logic as the rule's "smart" option).

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@not-an-aardvark not-an-aardvark added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Oct 18, 2016
@not-an-aardvark not-an-aardvark self-assigned this Oct 18, 2016
@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alberto, @sstur and @ilyavolodin to be potential reviewers.

@eslintbot
Copy link

LGTM

platinumazure
platinumazure approved these changes Oct 27, 2016
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gyandeeps
Copy link
Member

gyandeeps commented Oct 28, 2016 •
edited
Loading

should we mention in docs abt the only case we are fixing?

@eslintbot
Copy link

LGTM

@not-an-aardvark
Copy link
Member Author

Good idea, added a note to the docs.

@eslintbot
Copy link

LGTM

@nzakas nzakas removed the CLA: Valid label Oct 31, 2016
nzakas
nzakas approved these changes Nov 1, 2016
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Nov 1, 2016
@nzakas nzakas merged commit e58cead into master Nov 1, 2016
@not-an-aardvark not-an-aardvark deleted the eqeqeq-partial-fixer branch November 1, 2016 17:26
@not-an-aardvark not-an-aardvark mentioned this pull request May 12, 2017
Closed
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas nzakas approved these changes

+1 more reviewer

@platinumazure platinumazure platinumazure approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@not-an-aardvark not-an-aardvark

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@not-an-aardvark @mention-bot @eslintbot @gyandeeps @nzakas @platinumazure @jquerybot