Chore: Enable object-shorthand rule (refs #6407) #6812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| initializeConfig: /* istanbul ignore next */ function(callback) { | ||
| getConfigForStyleGuide, | ||
| processAnswers, | ||
| /* istanbul ignore next */initializeConfig(callback) { |
ef4b048 to
e6a6048
Compare
| @@ -65,7 +65,7 @@ function importPlugin(pluginRules, pluginName) { | |||
| * @param {string} ruleId Rule id (file name). | |||
| * @returns {Function} Rule handler. | |||
| */ | |||
| function get(ruleId) { | |||
| function getHandler(ruleId) { | |||
There was a problem hiding this comment.
Function renamed to avoid Node v4.x.x bug that treats shorthand properties named get as syntax errors.
e6a6048 to
5dfb581
Compare
|
LGTM |
|
LGTM, thanks for contributing! (Got a mocha timeout in the CLIEngine tests when running locally, but I can't imagine that would have anything to do with your changes.) |
|
@kaicataldo looks like a rebase is needed. |
d63eb5a to
78e0a19
Compare
78e0a19 to
473c21e
Compare
|
LGTM |
|
Rebased |
|
@kaicataldo Sorry but one more time plz. 😄 |
|
Maybe we should try splitting this up into batches? |
|
@nzakas Probably a good idea - I'll do that tonight. |
|
I'm not actually going to be able to get to this tonight, unfortunately. Will get to it ASAP. |
This was referenced Aug 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#6407
What changes did you make? (Give an overview)
Enabled
object-shorthandrule and ran auto-fix on codebase.Command used to make changes:
bin/eslint.js --no-eslintrc --rule 'object-shorthand: 2' --env 'es6' --fix lib bin conf packages tests Makefile.jsIs there anything you'd like reviewers to focus on?
Would love a few more pairs of eyes to scan all the changes to make sure they look good!
Pretty straightforward, aside from two things:
/* istanbul ignore next */comment to work for the shorthand notation (see this issue in the Istanbul repo for more info)getas a shorthand property name. We actually saw a bug report for this very situation and decided against fixing it, so my solution was to just rename the function. Will comment the specific location in the code.