-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Closed
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusionThere is consensus among the team that this change meets the criteria for inclusionarchived due to ageThis issue has been archived; please open a new issue for any further discussionThis issue has been archived; please open a new issue for any further discussioncoreRelates to ESLint's core APIs and featuresRelates to ESLint's core APIs and featuresenhancementThis change enhances an existing feature of ESLintThis change enhances an existing feature of ESLint
Description
As mentioned in #6395, the name of the rule "no-native-reassign" is confusing, because the rule covers more than native reassignments. The name was so misleading that no one realized the rule worked the way it did for several months. Therefore, I think the rule should be renamed to "no-global-assign".
One issue brought up in that thread was that a name change would be breaking. It doesn't have to be; we could have the old name (and docs url) alias the new one, promote the new name wherever possible, and mention the alias in the rule's documentation. Aliasing could be automated with metadata.
Metadata
Metadata
Assignees
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusionThere is consensus among the team that this change meets the criteria for inclusionarchived due to ageThis issue has been archived; please open a new issue for any further discussionThis issue has been archived; please open a new issue for any further discussioncoreRelates to ESLint's core APIs and featuresRelates to ESLint's core APIs and featuresenhancementThis change enhances an existing feature of ESLintThis change enhances an existing feature of ESLint