fix: check qErr != nil but return a nil value error err (#935)

alingse · web-flow · commit ccf35b9ad4d1 · 2024-12-15T06:40:24.000-08:00
diff --git a/internal/lint/code/comments.go b/internal/lint/code/comments.go
@@ -112,7 +112,7 @@ func GetComments(source []byte, lang *Language) ([]Comment, error) {
 	for _, query := range lang.Queries {
 		q, qErr := sitter.NewQuery([]byte(query), lang.Parser)
 		if qErr != nil {
-			return comments, err
+			return comments, qErr
 		}
 		comments = append(comments, engine.run(q, source)...)
 	}
diff --git a/internal/lint/lint.go b/internal/lint/lint.go
@@ -344,7 +344,7 @@ func (l *Linter) setup() error {
 func (l *Linter) teardown() error {
 	for _, pid := range l.pids {
 		if p, err := os.FindProcess(pid); err == nil {
-			if p.Kill() != nil {
+			if err := p.Kill(); err != nil {
 				return err
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ func GetComments(source []byte, lang *Language) ([]Comment, error) {`
`112`	`112`	`for _, query := range lang.Queries {`
`113`	`113`	`q, qErr := sitter.NewQuery([]byte(query), lang.Parser)`
`114`	`114`	`if qErr != nil {`
`115`		`- return comments, err`
	`115`	`+ return comments, qErr`
`116`	`116`	`}`
`117`	`117`	`comments = append(comments, engine.run(q, source)...)`
`118`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ func (l *Linter) setup() error {`
`344`	`344`	`func (l *Linter) teardown() error {`
`345`	`345`	`for _, pid := range l.pids {`
`346`	`346`	`if p, err := os.FindProcess(pid); err == nil {`
`347`		`- if p.Kill() != nil {`
	`347`	`+ if err := p.Kill(); err != nil {`
`348`	`348`	`return err`
`349`	`349`	`}`
`350`	`350`	`}`