Make rlx_util:parse_vsn parse integer versions #911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll resubmit the two fixes as two separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using integer release versions "1", "2" and so on instead of semver, like was possible in Relx 3. In current main branch this only seems to be an issue when creating relups without providing the previous version, in that case the crash happens at https://github.com/erlware/relx/blob/main/src/rlx_relup.erl#L95
I have also changed the returned value
0because it resulted in unhelpful crashes down the line because the code didn't expect an integer but a tuple.Tested against Erlang.mk tests.