Skip to content

rebar3 path doesn't include deps brought in by git subdir #2686

@robashton

Description

@robashton

Regarding changes made for #1923

If I run

rebar3 path

These won't be included (the goto example here would be a rebar.config with this dependency here)

{opentelemetry_api_experimental, {git_subdir, "http://github.com/open-telemetry/opentelemetry-erlang", {tag, "1.0.0"}, "apps/opentelemetry_api_experimental"}},

This is because much like in #2424, paths is calculated without going through the 'usual' mechanisms because that would be too slow.

ebin_dirs(Apps, State) ->
    lists:flatmap(fun(App) -> [io_lib:format("~ts/~ts/ebin", [rebar_dir:checkouts_out_dir(State), App]),
                               io_lib:format("~ts/~ts/ebin", [rebar_dir:deps_dir(State), App]) ] end, Apps).
priv_dirs(Apps, State) ->

Etc.

Sticking this issue up as a statement of intent, as a PR will be coming shortly. I suspect the right solution will be more band-aidy stuff of 'be aware of git-subdirs and get them into this path structure without incurring further build dependencies'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions