Skip to content

Conversation

jadeallenx
Copy link
Member

Closes #481

@Vagabond
Copy link
Member

This looks correct to me.

@jadeallenx jadeallenx merged commit c215a29 into master Dec 21, 2018
@jadeallenx jadeallenx deleted the gh481 branch December 21, 2018 22:52
@fenollp
Copy link

fenollp commented May 11, 2019

Any work around to this? Or plans to make this optional as @benoitc recommends?

I have an app using logger and that depends on amqp_client which uses lager. Updating said dep to next patch release just doesn’t log anything.

g-andrade added a commit to g-andrade/locus that referenced this pull request Aug 11, 2019
The way `error_logger` messages were forwarded to `logger` raised their level
for undetermined reasons (e.g. an info message became a notice.)

In order to fix this, invoke `logger` functions directly when they're available,
*unless* `lager` is also present and has sabotaged the default `logger` handler,
which would condemn our own `logger` messages into oblivion; in such cases, keep
using `error_logger` as `lager` will display those messages properly in any case.

Some information on the conflict between `logger` and `lager`:
* erlang-lager/lager#492
* erlang-lager/lager#488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config error_logger_redirect not working with OTP 21
4 participants