workflows: Stricter failure checks for hive tests #14115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somnathb1
commented
Mar 8, 2025
| @@ -83,7 +83,7 @@ jobs: | |||
| run_suite engine withdrawals | |||
| run_suite engine cancun | |||
| run_suite engine api | |||
| run_suite engine auth | |||
| # run_suite engine auth | |||
There was a problem hiding this comment.
The auth suite is bad as it uses outdated RPC calls
somnathb1
commented
Mar 8, 2025
| @@ -71,7 +71,7 @@ jobs: | |||
| echo "failed" > failed.log | |||
| exit 1 | |||
| fi | |||
| if (( failed*2 > tests )); then | |||
| if (( failed > 3 )); then | |||
There was a problem hiding this comment.
EESTs should not fail at all (failed = 0) unless there is a bug in the tests.
|
Tests green as of now |
yperbasis
approved these changes
Mar 9, 2025
somnathb1
added a commit
that referenced
this pull request
Mar 20, 2025
Increasing threshold to 10% failed
somnathb1
added a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing threshold to 10% failed