Skip to content

rehash with channel registration disabled is unsafe #2130

@slingamn

Description

@slingamn

Reported by eta in #ergo. loadRegisteredChannels does not check the current config value, which is probably correct: even if new channel registration is disallowed, we want to load existing registered channels. However, this case is buggy:

ergo/irc/server.go

Lines 705 to 707 in 4d9e80f

if !oldConfig.Channels.Registration.Enabled {
server.channels.loadRegisteredChannels(config)
}

This will unconditionally reload the registered channels and overwrite their entries in the channel manager. I think we can actually just delete this, since we are loading the registered channels unconditionally on startup?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions