Skip to content

Conversation

ismith
Copy link
Contributor

@ismith ismith commented Nov 8, 2021

Add a --fail flag to hard fail a la curl

If --fail is set, an error in the otelcli handler will cause an exit with status one. (Defaul behavior remains exit with status 0.)

This is intended for use cases like testing that an otlp endpoint is up
and receiving traffic.

Fixes #91.

If --fail is set, an error in the otelcli handler will cause an exit with status one. (Defaul behavior remains exit with status 0.)

This is intended for use cases like testing that an otlp endpoint is up
and receiving traffic.

Fixes equinix-labs#91.
@ismith ismith changed the title wip Add a --fail flag to hard fail a la curl Nov 8, 2021
@ismith ismith marked this pull request as ready for review November 8, 2021 03:31
@ismith
Copy link
Contributor Author

ismith commented Nov 16, 2021

Bump - @tobert WDYT of this approach to #91?

Copy link
Collaborator

@tobert tobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about what to do here and this is perfect. Thank you!

Will need some tests for it but the code looks fine.

@tobert tobert merged commit 07bd72f into equinix-labs:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use exit status to indicate failure of exec/span/etc.
2 participants