separate w3c traceparent to its own package #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 21, 2023 20:25
Still some leftover commented code that will move to protobuf span code.
Making it work consistently was a pain and the code was ugly so I decided to drop the feature where span/trace id would be zeroed if the trace isn't recording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traceparent code was still sitting in otlpclient after the breakup of CLI and OTLP because it was kinda a toss-up where it should land at that stage. It is now in its own package.
The
w3cdirectory is there, to make it clear it's not an otel-specific thing, and as a place to put a baggage API that's next after this PR merges.No new functionality. No changes to functional tests.