separate otlpclient code from CLI code #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 16, 2023 14:27
It passed before this refactor because there were bugs in the traceparent file and localhost detection code. Fortunately localhost detection failed closed, so no harm done, mostly. Bug fixes will come in following commits.
all tests pass now, no new functionality A bunch of otelcli funcs were made public. The interface isn't meant to protect anyone from themselves. Also refactored Cobra code and setup funcs to pass ctx and config around instead of relying on globals so the worst are gone. Some files in otlpclient might make more sense in otelcli, but this is already more than enough refactoring for one PR.
added 3 commits
June 20, 2023 10:16
otelcmd was a bad idea in progress from another branch, somehow snuck through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important change in this PR is that the
configglobal is now gone. Along the way a bunch of sites where the global was still accessed got fixed. In a few places, config is passed around more than snecessary but the PR had to stop somewhere.The code that relies on Cobra isn't as wound up with the OTLP client code now. It's also using relatively recent features in Cobra that allow for passing context.Context through to command functions, so now config can be plumbed without package globals. Since the cobra.Command declarations have moved to functions, they are no longer global, another win.
There are no new features in this PR. No major changes to the tests except to fix 2 gaps that were hiding 2 bugs, that are now fixed.