remove otlpserver.CliEvent #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 15, 2023 20:06
Big commit but everything was connected so it all kinda had to happen at once. Tests pass though :)
added 8 commits
June 15, 2023 20:39
Doesn't really belong in this PR but it was bothering me.
This is better than the old way :)
Also remove a no longer needed string manipulation in the grpc code.
|
(done) TODO: I think I forgot to re-implement checking the new ServerMeta map in the functional tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otlpserver.CliEvent was an idea from a long time ago to put spans and span events in the same list. This predated working directly with protobuf spans, which is now the norm in otel-cli. Mostly this is a cosmetic / internal change and should not impact any users.
otel-cli server tuihad some weird behavior that changed, but mostly it should be better and more accurate.