#42 add version subcommand #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing the new version functionality (not committed yet), my tests failed on these. They seem to have been broken a while so I also need to look into why previous test runs haven't failed me. Switched to cmp.Diff because it shows exactly what happened with little code where t.Fail() is a decision past-me made that I'm annoyed by now.
Adds a function to format version from ldflags. I originally open coded this in main() and as the feature came together it made more sense in the otelcli package so I moved it & tests here.
Adds vars in main that can be set by ldflags, and wires them up into the Cobra startup code in otelcli/root.go. At this point it should "just work" with goreleaser.
edw-eqix
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --version support via ldflags as suggested in #42.