Make the service/name CLI short args match the long args #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current mismatch of `-n / --service` and `-s / --name` is really confusing. I know this would probably have to be in some sort of major release, communicated beforehand, etc But I wanted to throw this PR out to start a discussion at least :)
|
omg sorry I missed this! 🤔 I don't want to break folks who are using the short options... but also you're totally right and I mesed that up! 😅 |
tobert
approved these changes
Jan 24, 2023
|
Thank you @tobert, this is such an awesome tool! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mismatch of
-n / --serviceand-s / --nameis really confusing.I know this would probably have to be in some sort of major release, communicated beforehand, etc
But I wanted to throw this PR out to start a discussion at least :)
Another option that wouldn't involve making a breaking change could be adding an alias like
-snforspanNameand-svfor--service