Skip to content

exec sends zero-length spans #189

@garthk

Description

@garthk

doExec needs to update the span's end time after calling child.Run. This does the trick but could be extracted for testing purposes:

    span.EndTimeUnixNano = uint64(time.Now().UnixNano())

Speaking of testing, if this was introduced in #175 without getting caught it suggests a gap in test coverage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions