Create entry-point to interact with neovim-qt #323
Conversation
|
Actually I was intending to do this upstream neovim/neovim#6917 but i never got to finish it. |
|
Any update on this? |
|
errr, nope, rebased but I dont have tests. If anyone wants to spin off the upstream PR, have a go at it |
|
It sounds like you're not open to merging this PR and would instead do this upstream. If that's so, can we close this? If not, can we merge so people can take advantage of the hook. |
|
Correct, I would prefer to see this upstream. There is little benefit to rushing it here, since you can also do it as a hack inside ginit.vim. Also one of the original points of #156 can only be fixed upstream. |
|
To me the changes in #158 did fix all what I expected, so it was good enough to have it merged here, and wait for an upstream solution with some easy workaround. Your pull request in neovim looked fine enough for me. Without being familiar with their internals, though. And there were tests, isn't it? I don't see what's missing there. |
|
@suy still missing that last comment neovim/neovim#6917 (comment) and the asserts are wrong and break the build. |
|
Closing this PR, since the behavior was implemented upstream with |
This PR is based on #156 and #158. The only difference is that it only
introduces the autocmd. So we can leave the shim loading optimization
for later.