[WIP] Implement clipboard provider #436
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9014461 to
2adf4d4
Compare
0b7a961 to
b76ffbe
Compare
a255b8a to
7bcfa24
Compare
cf8dba4 to
409544a
Compare
Merged
409544a to
b2fccb8
Compare
0c9f616 to
bfcacbc
Compare
added 3 commits
September 5, 2018 18:44
This commit does not alter default behaviour of the GUI, it only adds the necessary RPC methods to get/set the clipboard. - Vim (and Neovim) stores the selection type along with data in the clipboard. To achieve this the selection type (a string) is stored in the clipboard with the mimetype application/x-nvim-selection-type. - In Windows/Mac both the * and + registers are the system clipboard A clipboard provider is included in the test directory that forwards clipboard operations to the gui. But we will have to push upstream to support regular functions for the clipboard provider. Also took the chance to - remove the checkCommand in tst_shell.cpp, there was a race condition the tests that used it for the font commands - Added some debugging and error reporting
bfcacbc to
b8e33b5
Compare
4517026 to
2dc88a9
Compare
|
Replaced by #479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clipboard provider implemented by the GUI
It currently supports both clipboards and stores the selection type. Big question now is what happens with multiple GUIs attached, etc.
This is based on the approach from neovim-gtk. As it stands the call signatures are not compatible,
but I think they could be.we use all the arguments in the set event and the api in neovim-gtk only passes arg0 and 2. The event names are different so there should be no conflict.TODO
Add guards to the provider, merge with the shim, etcref #298