Draft: Support for throw new Exception encoded as assert(false) fixes #1512
#1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert(false)assert(false)
|
TODO:
|
|
Also rebase so we see changes more easily. :) |
vkuncak
approved these changes
May 8, 2024
| @@ -31,10 +31,8 @@ class ExceptionLifting(override val s: Trees, override val t: imperative.Trees) | |||
|
|
|||
| override def transform(e: s.Expr): t.Expr = e match { | |||
| case s.Throw(exc) => | |||
| println("SAM IN TRANSFORM THROW CASE") | |||
| t.Assert(t.BooleanLiteral(false), Some(f"throw $exc"), t.UnitLiteral()) | |||
| t.Assert(t.BooleanLiteral(false).setPos(e), Some(f"throw $exc unreachable"), t.NoTree(transform(fd.returnType)).setPos(e)).setPos(e) | |||
There was a problem hiding this comment.
@mario-bucev can you have a look at these setPos? When we only do setPos on the outer tree, the position is not reported. Hence this puts it everywhere, but that seems a bit brute force. Is there some guideline which position needs to be set for assert to report a meaningful line number?
There was a problem hiding this comment.
For the VC position, it's the condition position that matters. However, it's also a good practice to put the position on the outer tree as well since later phases will rely on its position (not only that, but it's also easier to debug).
assert(false)assert(false) fixes #1512
assert(false) fixes #1512assert(false)
assert(false) assert(false) fixes #1512
6a1104e to
c7b14a1
Compare
c7b14a1 to
de795bf
Compare
samuelchassot
commented
May 13, 2024
core/src/main/scala/stainless/extraction/imperative/Trees.scala
Outdated
Show resolved
Hide resolved
|
You need to fix i800b.scala since the message for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.