Disable test i1306b
#1478
Merged
Disable test i1306b
#1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuncak
approved these changes
Nov 8, 2023
| var i: BigInt = 0 | ||
| def nextIncrement = i + 1 | ||
| def accessI(x: BigInt, y: BigInt) = i + x + y | ||
| def modifyI(x: BigInt, y: BigInt) = { i += x + y } |
There was a problem hiding this comment.
@mario-bucev Function modify is introduced but not used, is this on purpose, to test that its presence does not cause any issues?
There was a problem hiding this comment.
Good catch, since this test is derived from i1306b, I do not remember exactly why I've added this function... I'll call it with nullifying arguments.
There was a problem hiding this comment.
I've also added a variant of the function that increments i with modifyI.
4b0615c to
5934749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i1306bis a nice test to ensure we do not regress on #1306 but it is sadly quite flaky.I have disabled it (not deleted it) and have added a variant
i1306cthat does not make use of non-linear arithmetic (which seems to be the cause of the issue).