-
Notifications
You must be signed in to change notification settings - Fork 600
Closed
Description
PlotPieChart
and RenderHeatmap
call sprintf
with a provided format string, which is unsafe.
Line 1909 in 4fcc6e0
sprintf(buffer, fmt, (double)values[i]); |
Line 2063 in 4fcc6e0
sprintf(buff, fmt, values[i]); |
This can lead to a simple buffer overflow, if the provided format string causes >32 characters of output, but it may also allow writing to arbitrary memory locations by using %n
and reading local stack addresses using %p
.
I don't know if there are ways to handle the second two issues, but using snprintf
instead of sprintf
should prevent potential buffer overflows.
Metadata
Metadata
Assignees
Labels
No labels