-
Notifications
You must be signed in to change notification settings - Fork 90
Documenting more details of the "Update Envoy" process. #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
requested changes
Feb 6, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
This makes editing the raw file easier. Signed-off-by: Jakub Sobon <mumak@google.com>
@oschaaf, PTAL. Also reformatted the file (added line breaks) as reading / editing it in raw format is getting harder. |
Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
previously approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm
dubious90
previously approved these changes
Feb 8, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
dubious90
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.bazelrc
with#unique
. To make it easier to spot them.MAINTAINERS.md
, adding line breaks at 80 char where appropriate.