Skip to content

Conversation

mum4k
Copy link
Collaborator

@mum4k mum4k commented Feb 6, 2021

  • Step by step guide on how to perform the update.
  • Marking our local changes in .bazelrc with #unique. To make it easier to spot them.
  • Reformatting MAINTAINERS.md, adding line breaks at 80 char where appropriate.

@mum4k mum4k requested a review from oschaaf February 6, 2021 05:55
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Feb 6, 2021
mum4k added 2 commits February 6, 2021 01:13
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
@oschaaf oschaaf added waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. and removed waiting-for-review A PR waiting for a review. labels Feb 6, 2021
mum4k added 3 commits February 7, 2021 21:48
Signed-off-by: Jakub Sobon <mumak@google.com>
This makes editing the raw file easier.

Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k
Copy link
Collaborator Author

mum4k commented Feb 8, 2021

@oschaaf, PTAL. Also reformatted the file (added line breaks) as reading / editing it in raw format is getting harder.

@mum4k mum4k requested a review from dubious90 February 8, 2021 02:59
@mum4k mum4k added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Feb 8, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
oschaaf previously approved these changes Feb 8, 2021
Copy link
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

dubious90
dubious90 previously approved these changes Feb 8, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k dismissed stale reviews from dubious90 and oschaaf via 3396540 February 9, 2021 00:21
@dubious90 dubious90 merged commit 852069b into envoyproxy:main Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants