Skip to content

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Feb 5, 2021

I think the root cause is that the alpine-glibc image updates,
and through that dependency requirements can no longer be met.

This PR

  • pins the alpine image at the latest version
  • changes the dependency versions so they work again

Note: the >= for python was changed to = as otherwise we'd
write a file to disk mentioning the version, this seemed contra
intent.

There's a complaint [1] emitted during the image build, so we need to
see if everything is OK when CI finishes.

[1] /usr/glibc-compat/sbin/ldconfig: /usr/glibc-compat/lib/ld-linux-x86-64.so.2 is not a symbolic link

Signed-off-by: Otto van der Schaaf ovanders@redhat.com

I think the root cause is that the alpine-glibc image updates,
and through that dependency requirements can no longer be met.

This PR
- pins the alpine image at the latest version
- changes the dependency versions so they work again

Note: the `>=` for python was changed to `=` as otherwise we'd
write a file to disk mentioning the version, this seemed contra
intent.

There's a complaint [1] emitted during the image build, so we need to
see if everything is OK when CI finishes.

[1] /usr/glibc-compat/sbin/ldconfig: /usr/glibc-compat/lib/ld-linux-x86-64.so.2 is not a symbolic link

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Feb 5, 2021
@oschaaf
Copy link
Member Author

oschaaf commented Feb 5, 2021

Thanks to @abaptiste for help with assessing the root cause.

@dubious90
Copy link
Contributor

Thanks Otto! This looks good. Once I confirm the CI passes, I will merge this through

@dubious90 dubious90 self-assigned this Feb 5, 2021
@oschaaf
Copy link
Member Author

oschaaf commented Feb 5, 2021

Allright, CI all green here.

@dubious90 dubious90 merged commit 796c718 into envoyproxy:main Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants