Fix potential hangs on exit & cap drain wait time #628
Conversation
- don't set up a drain callback when there are no active connections - set up a timer that will cap the amount of time we wait for the pool to drain. - disable latency measurement when commencing the drain procedure, as by that time we are no longer interested in it, and in particular don't want to hear about any warnings issued by the Statistic implementation about recorded values being too large. Fixes envoyproxy#627 Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
|
I think I may have an idea for how to add an integration tests for this, but the problem is that this would rely on timing, |
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
- Attempt to fix asan-detected leak - Add more timing slack to integration test, as CI needs it. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
|
Agreed that the integration test may be brittle. Arguably we don't really have sufficient coverage just from the unit test, since it heavily relies on mocks. Therefore the addition of the integration test is still the right choice. I am assuming it was executed it a good amount of times and it isn't inherently flaky. Merging in since it is marked as |
to drain.
by that time we are no longer interested in it, and in particular
don't want to hear about any warnings issued by the Statistic
implementation about recorded values being too large.
Fixes #627
Signed-off-by: Otto van der Schaaf ovanders@redhat.com