Updating repository paths in README under benchmarks. #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing github repository paths from oschaaf to envoyproxy. Signed-off-by: Jakub Sobon <mumak@google.com>
|
@oschaaf there is also a reference to |
|
@oschaaf please see my question about the reference to |
Oh, sorry I missed that. I think that for the time being it's the best option, because we don't push the image in CI to a proper location. There's https://hub.docker.com/r/envoyproxy/nighthawk-dev, maybe we should try to also obtain https://hub.docker.com/r/envoyproxy/nighthawk-benchmark-dev (or some such) as a location to push to. |
|
(Filed #611 to track) |
|
Thank you @oschaaf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing github repository paths from oschaaf to envoyproxy.
Signed-off-by: Jakub Sobon mumak@google.com