Skip to content

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Nov 10, 2020

  • Handle return value of encodeHeaders() now that there is one.
  • MetricSnapshotImpl now needs a TimeSource in its constructor.
  • Avoid assert, use valid request header in StreamDecoderTest

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

- Handle return value of encodeHeaders() now that there is one.
- MetricSnapshotImpl now needs a TimeSource in its constructor.
- Avoid assert, use valid request header in StreamDecoderTest

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Nov 10, 2020
@mum4k
Copy link
Collaborator

mum4k commented Nov 11, 2020

Ready for merging, blocked on the clang_tidy flake which we are planning to remove temporarily in the near future (#570).

@mum4k
Copy link
Collaborator

mum4k commented Nov 11, 2020

Please merge from master to remove the hard block on clang_tidy.

@mum4k mum4k added waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. and removed waiting-for-review A PR waiting for a review. labels Nov 11, 2020
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Nov 11, 2020
@mum4k mum4k merged commit 350c2d3 into envoyproxy:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants